[Android-3721] Copy design module from publish to samples app#8
Open
hackertronix wants to merge 1 commit intomainfrom
Open
[Android-3721] Copy design module from publish to samples app#8hackertronix wants to merge 1 commit intomainfrom
hackertronix wants to merge 1 commit intomainfrom
Conversation
hackertronix
force-pushed
the
task/copy-design-module-to-samples
branch
from
415dac6 to
58dace1
Compare
Contributor
Author
|
@hitherejoe Would you be able to look at this? :) |
hitherejoe
reviewed
Sep 23, 2020
| } | ||
| } | ||
| dependencies { | ||
| api project(':app') |
Collaborator
There was a problem hiding this comment.
how come design needs to know about app?
hitherejoe
requested changes
Sep 23, 2020
Collaborator
hitherejoe
left a comment
hitherejoe
left a comment
There was a problem hiding this comment.
This will be great for sharing the theme around! I left a comment, I'm not sure why design depends on the app module
Also, the App module is what we release as the library, so with this change design will never actually be available to users of the library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👆️
This is copied over without any changes from the publish repo
Jira Ticket
https://buffer.atlassian.net/browse/ANDROID-3721